cat-log: list out/err files when available via tailer #6480
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
oliver-sanders
force-pushed
the
cat-log-list-tailable-files
branch
4 times, most recently
from
320f8f4 to
39e17e5
Compare
oliver-sanders
force-pushed
the
cat-log-list-tailable-files
branch
from
39e17e5 to
f8a248c
Compare
| proc = remote_cylc_cmd( | ||
| cmd, | ||
| platform, | ||
| capture_process=False, | ||
| capture_process=(mode == 'list-dir'), | ||
| manage=(mode == 'tail'), | ||
| text=False | ||
| text=(mode == 'list-dir'), | ||
| ) | ||
| if ( | ||
| mode == 'list-dir' | ||
| and os.path.exists( | ||
| os.path.join( | ||
| local_log_dir, | ||
| 'job-activity.log' | ||
| ) | ||
| ) | ||
| ): | ||
| # add the local-only job-activity.log file to the remote-list | ||
| print('job-activity.log') | ||
|
|
||
| # add and missing items to file listing results | ||
| if isinstance(proc, Popen): | ||
| # i.e: if mode=='list-dir' and ctrl+c not pressed | ||
| out, err = proc.communicate() |
There was a problem hiding this comment.
I think we need to include the proc.communicate() in the suppressing of the KeyboardInterrupt
There was a problem hiding this comment.
This is a suppress block, so the code execution will continue on if KeyboardInterrupt is caught leading to an error further on in the code.
As it stands, if you ctrl+c here, you'll get a KeyboardInterrupt traceback:
Traceback (most recent call last):
...
KeyboardInterrupt
But if we do the awaiting inside this block, it just turns into a different error:
Traceback (most recent call last):
...
File "cylc/flow/scripts/cat_log.py", line 607, in _main
AttributeError: 'NoneType' object has no attribute 'splitlines'
I don't think kill signals are very well handled here at present, not really the fault of this PR.
There was a problem hiding this comment.
If the whole if isinstance block is included in the suppress block, it avoids traceback on ctrl+c. But not that important I guess
There was a problem hiding this comment.
The traceback is a cosmetic problem, but I think there are pre-existing functional issues here, #6609
oliver-sanders
force-pushed
the
cat-log-list-tailable-files
branch
from
d46501f to
beb2a09
Compare
* The `--mode=list-dir` option lists log files which are available to view. * This commit includes remote `job.out` and `job.err` files which are available via platform tailer/viewer commands. * Note, these log files are only listed if accessible via *both* a tailer and a viewer in order to prevent ambiguity (these are typically configured together anyway).
oliver-sanders
force-pushed
the
cat-log-list-tailable-files
branch
from
beb2a09 to
4714a46
Compare
I think we need to do more than just swallow the traceback. Have opened an issue: #6609 |
Closes #5802
List log files that are not present on disk but which are available via a tailer.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.